The branch main has been updated by markj:
URL:
https://cgit.FreeBSD.org/src/commit/?id=35d05a14ed7e9935be1ed0fe965b91aaaa4c92ef
commit 35d05a14ed7e9935be1ed0fe965b91aaaa4c92ef
Author: Mark Johnston <ma...@freebsd.org>
AuthorDate: 2024-10-26 21:04:59 +0000
Commit: Mark Johnston <ma...@freebsd.org>
CommitDate: 2024-10-26 21:05:40 +0000
igc: Remove a bogus register write in igc_if_queues_free()
As explained in PR 277038, iflib calls IFDI_DETACH() and then
IFDI_QUEUES_FREE(). With igc, the latter writes to a register after it
has been unmapped.
igc_if_detach() already calls igc_release_hw_control(), and looking at
callers of igc_if_queues_free(), that appears to be sufficient. So,
just remove the igc_release_hw_control() call.
PR: 277038
Reported by: Mike Belanger <mibelan...@qnx.com>
Reviewed by: kbowling
Tested by: kbowling
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D47293
---
sys/dev/igc/if_igc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c
index dd89b27e134c..38fb1406b1c1 100644
--- a/sys/dev/igc/if_igc.c
+++ b/sys/dev/igc/if_igc.c
@@ -2050,8 +2050,6 @@ igc_if_queues_free(if_ctx_t ctx)
sc->rx_queues = NULL;
}
- igc_release_hw_control(sc);
-
if (sc->mta != NULL) {
free(sc->mta, M_DEVBUF);
}
