On 8/16/25 22:27, Lexi Winter wrote:
The branch main has been updated by ivy:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=c6778f3a4423743a3f30d8d09bc4e4a086863928

commit c6778f3a4423743a3f30d8d09bc4e4a086863928
Author:     Lexi Winter <i...@freebsd.org>
AuthorDate: 2025-08-17 01:19:21 +0000
Commit:     Lexi Winter <i...@freebsd.org>
CommitDate: 2025-08-17 01:19:21 +0000

     Makefile.libcompat: Tweak krb5 compat dirs
krb5/util contains both programs and libraries; trying to build that
     for compat confuses bsd.prog.mk and results in unwanted files being
     created in the source tree.  Remove krb5/util and instead list only
     the directories underneath krb5/util which contain libraries.
The libdata change from the diff isn't included; that will be fixed
     in a different way.
Fixes: fb13ae28b2e8 ("Makefile.libcompat: Add krb5/util")
     Reviewed by:    ngie (previous version)
     Differential Revision:  https://reviews.freebsd.org/D51937

Why not just move these directories over to krb5/lib?  In fact, I'm not sure
why we need a separate krb5/util at all really?  Hmm, it seems it builds some
bootstrap tools as well as libraries.  Note that the order you used
here doesn't match the order that krb5/util/Makefile seems to want:

SUBDIR= build-tools compile_et .WAIT \
        support .WAIT \
        et .WAIT \
        ss profile verto

It does seem though that we could just move the libraries at least into
krb5/lib and use .WAIT when needed leaving only build-tools and compile_et
in krb5/util?

--
John Baldwin


Reply via email to