On Thu, Aug 21, 2025 at 1:02 AM Bjoern A. Zeeb <b...@freebsd.org> wrote:
> On Thu, 21 Aug 2025, Toomas Soome wrote: > > >> shot in the dark (haven't checked that LOADER_NET_SUPPORT would be > defined for these files): > > > > > > I do not think it is the approach you want to take there, because this > means you would need to build all those variants to build different > components… > > > > I would think of having weak is_tftp() implementation returning false > for case the dev_net.c is not built or move dev_net.c into libsa. I’m not > quite sure why dev_net.c is outside libsa anyhow;) > > Even just moving is_tftp into stand.h would work. > Even better: deleting it entirely. It's not a good solution to the problem. But it's a better solution than what we had before. It will be gone when I do my next loader tech debt reduction pass. I didn't have time to do that before the release, so simon's changes went in. He's since committed an adequate fix. Warner
