So currently, the remaining problem is only on the keyboard LED? Would you mind to create a PR so that we can move discusion to a more suitable place? I would like to ask you more question over your environment.
Cy Schubert <cy.schub...@cschubert.com> writes: > On Sat, 23 Aug 2025 20:37:34 -0700 > Cy Schubert <cy.schub...@cschubert.com> wrote: > >> On Sat, 23 Aug 2025 13:27:23 -0400 >> ShengYi Hung <aokbl...@freebsd.org> wrote: >> >> > Hello: >> > >> > I only submit two patches. What is the third patch you have mentioned? >> > Is the one setting "sysctl usbhid=1"? >> > >> > On 8/23/25 13:10, Cy Schubert wrote: >> > > In message <m2frdicwrx....@freebsd.org>, ShengYi Hung writes: >> > >> Hello, thanks for the reminder. I compile the standalone module to test >> > >> so >> > >> didn't discover that. Fix it right now. >> > >> Gordon Bergling <g...@freebsd.org> writes: >> > >> >> > >> >> > >>> Hi ShengYi, >> > >>> >> > >>> On Sat, Aug 23, 2025 at 04:50:59AM +0000, ShengYi Hung wrote: >> > >>>> The branch main has been updated by aokblast: >> > >>>> >> > >>>> URL: >> > >>>> https://cgit.FreeBSD.org/src/commit/?id=1685192ea1faac28f2d4feede53e7 >> > >>>> >> > >> 0b6a380500f >> > >>>> commit 1685192ea1faac28f2d4feede53e70b6a380500f >> > >>>> Author: ShengYi Hung <aokbl...@freebsd.org> >> > >>>> AuthorDate: 2025-08-21 17:59:15 +0000 >> > >>>> Commit: ShengYi Hung <aokbl...@freebsd.org> >> > >>>> CommitDate: 2025-08-23 04:50:09 +0000 >> > >>>> >> > >>>> hkbd: remove erorr detection in KDSKBSTATE ioctl >> > >>>> >> > >>>> The KDSKBSTATE ioctl brings the LED up. However, some keyboards >> > >>>> (like >> > >> qemu >> > >>>> keyboard) may not have LED or failed to set the LED due to >> > >>>> unexpected >> > >> reason. >> > >>>> Therefore, removing the error check as ukbd(4) does allow the >> > >>>> keyboard >> > >> works >> > >>>> correctly with kbdcontrol(4). >> > >>>> >> > >>>> Also move hw.hid.hkbd.no_leds sysctl out of HID_BUG thus users >> > >>>> can >> > >>>> disable setting LEDs >> > >>>> >> > >>>> PR: 288968 >> > >>>> Reviewed by: wulf >> > >>>> Tested by: trash...@ellael.org, marklmi26-f...@yahoo.com, >> > >>>> trkelle >> > >> r...@gmail.coom >> > >>>> Approved by: lwsu (mentor), markj (mentor) >> > >>>> MFC after 1 week >> > >>>> Sponsored by: The FreeBSD Foundation >> > >>>> Differential Revision: https://reviews.freebsd.org/D52101 >> > >>>> >> > >>>> mvalsmva >> > >>>> --- >> > >>> I am not sure how this is related, but since that commit, buildkernel >> > >>> of GE >> > >> NERIC is broken both >> > >>> on amd64 and aarch64. The following error is from an amd64 build, >> > >>> aarch64 i >> > >> s the same. >> > >>> ----------------------------- >> > >>> /storage/freebsd/src/current/sys/dev/hid/hkbd.c:1831:10: error: >> > >>> called ob >> > >> ject type 'char[5]' is not a function or function pointer >> > >>> 1831 | DPRINTF(("error %d", error)); >> > >>> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~ >> > >>> /storage/freebsd/src/current/sys/dev/hid/hid.h:212:34: note: >> > >>> expanded fro >> > >> m macro 'DPRINTF' >> > >>> 212 | #define DPRINTF(...) DPRINTFN(1, __VA_ARGS__) >> > >>> | ~~~~~~~~~~~~^~~~~~~~~~~~ >> > >>> /storage/freebsd/src/current/sys/dev/hid/hid.h:208:17: note: >> > >>> expanded fro >> > >> m macro 'DPRINTFN' >> > >>> 208 | printf("%s: " fmt, \ >> > >>> | ~~~~~~ ^ >> > >>> 1 error generated. >> > >>> --- hkbd.o --- >> > >>> *** [hkbd.o] Error code 1 >> > >>> ----------------------------- >> > >>> >> > >>> --Gordon >> > >> -- >> > >> Best Regards. >> > >> ShengYi Hung. >> > >> >> > > My machines running X (laptops), >> > > >> > > - the right mouse key no longer works under X, I can no longer use X, >> > > - the caps-lock light will not display under X >> > > - on the text console works, X does not. >> > > >> > > The three commits related have bee reverted locally, functionality has >> > > returned. >> > > >> > > >> > Best Regards. >> > >> > ShengYi Hung. >> > >> >> The hashes are, >> >> 1685192ea1fa >> 8a847947153e >> 6ea7e1f92882 >> >> I don't think 8a847947153e is related. 6ea7e1f92882 must be reverted in >> order to revert 1685192ea1fa. >> > > I reapplied the patches. The problem persisted. A clean kernel build > also works around the problem. > > There is still a problem with the caps lock LED. It works on the > console while under X it will not light until the first non-shift key > is hit. I can live with that. -- Best Regards. ShengYi Hung.
