On 9/3/25 22:45, Jake Freeland wrote:
The branch main has been updated by jfree:
URL:
https://cgit.FreeBSD.org/src/commit/?id=9404c479946c00b6ac94253d2037c47251dc606c
commit 9404c479946c00b6ac94253d2037c47251dc606c
Author: Jake Freeland <jf...@freebsd.org>
AuthorDate: 2025-09-04 02:42:23 +0000
Commit: Jake Freeland <jf...@freebsd.org>
CommitDate: 2025-09-04 02:42:23 +0000
pci_user: Report NUMA domain
A PCI device's NUMA domain is now accessible via the pd_numa_domain
member of struct pci_conf when using the PCIOCGETCONF ioctl.
A new ioctl number has been assigned to PCIOCGETCONF to preserve
compatibility with binaries compiled on FreeBSD versions 7 through 14.
Such binaries can continue to use the PCIOCGETCONF ioctl number
that they were compiled with and experience no ABI repercussions.
Reviewed by: imp, markj
Differential Revision: https://reviews.freebsd.org/D44289
For future reference: you didn't need to bump to a new number for the ioctl
since the size of the argument is encoded in the ioctl as well. This
feature of ioctls also means that we generally don't add padding (as you did
in the followup commit) as you will naturally get a new ioctl cmd value
anytime you add more fields in the future. This avoids the one point Warner
raised in the review about how do you define the semantics of the padding
as that approach defers reserving space in the structure until the semantics
of that space is known.
--
John Baldwin
