The branch main has been updated by imp:
URL:
https://cgit.FreeBSD.org/src/commit/?id=52096ba6b7692ca204214959b8efffae87efa652
commit 52096ba6b7692ca204214959b8efffae87efa652
Author: Warner Losh <i...@freebsd.org>
AuthorDate: 2025-09-14 17:29:40 +0000
Commit: Warner Losh <i...@freebsd.org>
CommitDate: 2025-09-14 17:29:40 +0000
mpi3mr: Get rid of a supurious printf
If we have outstanding tractions and then poll and still have
outstanding transactions, we print a warning. However, we print the
warning, confusingly, even if there's 0 left. Enclose the two statements
in {} to avoid this relatively harmless effect and quiet gcc12's
indentation complaint.
Sponsored by: Netflix
---
sys/dev/mpi3mr/mpi3mr_cam.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sys/dev/mpi3mr/mpi3mr_cam.c b/sys/dev/mpi3mr/mpi3mr_cam.c
index 77e25339a1a9..a5120e2788db 100644
--- a/sys/dev/mpi3mr/mpi3mr_cam.c
+++ b/sys/dev/mpi3mr/mpi3mr_cam.c
@@ -1856,10 +1856,11 @@ int mpi3mr_remove_device_from_os(struct mpi3mr_softc
*sc, U16 handle)
"Poll reply queue once\n", target_outstanding,
target->per_id);
mpi3mr_poll_pend_io_completions(sc);
target_outstanding = mpi3mr_atomic_read(&target->outstanding);
- if (target_outstanding)
+ if (target_outstanding) {
target_outstanding =
mpi3mr_atomic_read(&target->outstanding);
mpi3mr_dprint(sc, MPI3MR_ERROR, "[%2d] outstanding IOs
present on target: %d "
- "despite poll\n", target_outstanding,
target->per_id);
+ "despite poll\n", target_outstanding,
target->per_id);
+ }
}
if (target->exposed_to_os && !sc->reset_in_progress) {
