> On Mar 3, 2026, at 11:26 AM, Siva Mahadevan <[email protected]> wrote: > > The branch main has been updated by siva: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=f26cb4757eb74ceace39144933ae198ebf1b4f28 > > commit f26cb4757eb74ceace39144933ae198ebf1b4f28 > Author: Siva Mahadevan <[email protected]> > AuthorDate: 2026-03-03 19:09:35 +0000 > Commit: Siva Mahadevan <[email protected]> > CommitDate: 2026-03-03 19:19:32 +0000 > > LinuxKPI: avoid -Werror=unused-value in sort() from BUILD_BUG_ON_ZERO() > > The BUILD_BUG_ON_ZERO() macro returns an (int)0 if it does not fail > at build time. LinuxKPI sort() has it as a guard for an unsupported > argument but ignores the return value. > > This leads to gcc complaining: > > /usr/src/sys/compat/linuxkpi/common/include/linux/build_bug.h:60:33: > error: statement with no effect [-Werror=unused-value] > 60 | #define BUILD_BUG_ON_ZERO(x) ((int)sizeof(struct { int:-((x) != > 0); })) > | ^ > /usr/src/sys/compat/linuxkpi/common/include/linux/sort.h:37:9: note: in > expansion of macro 'BUILD_BUG_ON_ZERO' > 37 | BUILD_BUG_ON_ZERO(swap); \ > | ^~~~~~~~~~~~~~~~~ > /usr/src/sys/contrib/dev/rtw89/core.c:2575:9: note: in expansion of macro > 'sort' > 2575 | sort(drift, RTW89_BCN_TRACK_STAT_NR, sizeof(*drift), > cmp_u16, NULL); > > Change to BUILD_BUG_ON() for the statement version.
Thank you Siva! My mailbox and the gcc tinderbox build thanks you :).. -Enji
