The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=aca53fc2a6879f45dcbe1a60f91f14a5f6d48448
commit aca53fc2a6879f45dcbe1a60f91f14a5f6d48448 Author: Dimitry Andric <[email protected]> AuthorDate: 2026-09-18 07:07:46 +0000 Commit: Dimitry Andric <[email protected]> CommitDate: 2026-09-20 07:01:47 +0000 Fix statement with no effect in linuxkpi's xarray.h When compiling the kernel with gcc 14, errors similar to the following are emitted: sys/dev/cxgbe/iw_cxgbe/ev.c: In function 'c4iw_ev_handler': sys/compat/linuxkpi/common/include/linux/xarray.h:132:23: error: statement with no effect [-Werror=unused-value] 132 | flags == 0; \ sys/dev/cxgbe/iw_cxgbe/ev.c:274:17: note: in expansion of macro 'xa_unlock_irqrestore' 274 | xa_unlock_irqrestore(&dev->cqs, flag); | ^~~~~~~~~~~~~~~~~~~~ sys/compat/linuxkpi/common/include/linux/xarray.h:132:23: error: statement with no effect [-Werror=unused-value] 132 | flags == 0; \ sys/dev/cxgbe/iw_cxgbe/ev.c:283:17: note: in expansion of macro 'xa_unlock_irqrestore' 283 | xa_unlock_irqrestore(&dev->cqs, flag); | ^~~~~~~~~~~~~~~~~~~~ It looks like the intent of the "flags == 0" statement was to make the 'flags' macro argument not unused, but it still results in a warning. Use the construct "(void)flags" instead. Reviewed by: bz MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D59787 --- sys/compat/linuxkpi/common/include/linux/xarray.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/include/linux/xarray.h b/sys/compat/linuxkpi/common/include/linux/xarray.h index a5b53b923719..10c10602407d 100644 --- a/sys/compat/linuxkpi/common/include/linux/xarray.h +++ b/sys/compat/linuxkpi/common/include/linux/xarray.h @@ -129,7 +129,7 @@ void *__xa_next(struct xarray *, unsigned long *, bool); #define xa_unlock_irqrestore(xa, flags) \ do { \ xa_unlock((xa)); \ - flags == 0; \ + (void)flags; \ } while (0) static inline int
