On Fri, Jan 08, 2021 at 02:49:31AM +0300, Vladimir Kondratyev wrote: > On 08.01.2021 02:41, Ravi Pokala wrote: > > -----Original Message----- > > From: <owner-src-committ...@freebsd.org> on behalf of Vladimir Kondratyev > > <vladi...@kondratyev.su> > > Date: 2021-01-07, Thursday at 15:33 > > To: Jessica Clarke <jrt...@freebsd.org>, Vladimir Kondratyev > > <w...@freebsd.org> > > Cc: "src-committ...@freebsd.org" <src-committ...@freebsd.org>, > > "dev-commits-src-...@freebsd.org" <dev-commits-src-...@freebsd.org>, > > "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> > > Subject: Re: git: 92cf602e3809 - main - Copy strcasestr.c from libc to > > libkern. > > > > On 08.01.2021 02:27, Jessica Clarke wrote: > > > On 7 Jan 2021, at 23:20, Vladimir Kondratyev <w...@freebsd.org> wrote: > > >> +#include <ctype.h> > > >> +#include <string.h> > > >> +#include "xlocale_private.h" > > >> + > > >> +/* > > >> + * Find the first occurrence of find in s, ignore case. > > >> + */ > > >> +char * > > >> +strcasestr_l(const char *s, const char *find, locale_t locale) > > > > > > Locales in the kernel? This feels wrong. > > > > > > Jess > > > > > > > strcasestr.c was copied from userland unmodified just to allow > > "git log --follow" to work. Next commit removed locale support from this > > file and connected it to build. > > > > Unfortunately, about two-dozen commit messages from you arrived at the same > > time, and some were out of order; without incrementing change numbers in > > the subject line, figuring out the actual ordering is non-trivial. :-p > > > > -Ravi (rpokala@) > > > > I hope, commit hook will be improved some day. Pushing of two-dozen > commits one by one is too boring.
The history is in the right order and gitlog/cgit/anything that reads the log show everything in the right order. mails are asynchronuous, expecting the mail to always arrive in a given order is wrong ;) pushing all those commits at once was imho the right thing to do. Best regards, Bapt
signature.asc
Description: PGP signature
