On 2/9/21, Jessica Clarke <jrt...@freebsd.org> wrote: > Here's your review after reading through it for <5 minutes today: > > On 8 Feb 2021, at 19:15, Mateusz Guzik <m...@freebsd.org> wrote: >> + leaq (%r11,%r8),%rcx >> + notq %r11 >> + andq %r11,%rcx >> + andq %r9,%rcx >> ... >> + leaq (%r11,%r8),%rcx >> + notq %r11 >> + andq %rcx,%r11 > > These look the wrong way round (but you got it the right way round > above). >
Indeed, solid brainfart. Interesting this still passed the test suite. Thank you for noting this. However, your response does not really address any of the points I raised in my e-mail. >> + andq %r9,%rcx > > Jess > > -- Mateusz Guzik <mjguzik gmail.com> _______________________________________________ dev-commits-src-main@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main To unsubscribe, send any mail to "dev-commits-src-main-unsubscr...@freebsd.org"
