On 15 May 2021, at 23:36, Lutz Donnerhacke <l...@donnerhacke.de> wrote: > > On Sun, May 16, 2021 at 12:30:54AM +0300, Konstantin Belousov wrote: >>> The LIBALIAS_LOCK_ASSERT and the variable declarations were not moved. >> So you changed some style, but left the large violation in place. > > This cleanup is a preparation to fix various issues in this code. > So yes, the change was intentionally limited to style issues. > > Mixing style and functional changes makes it very hard to track down a > broken behavior to a single commit. This change is huge, it must not break > anything.
I think you two are talking past each other. kib@’s point is that some of the changes made in this commit were style *changes* not style *fixes* (i.e. the code was compliant before, you’ve just changed it from one acceptable formatting to another), and that there were instances of significant style violations *not* fixed (e.g. the assertion macro before variable declarations pointed out). He is not talking about functional violations, only style ones. However, in your defence, your original commit did not claim to fix *all* style violations, only "most annoying style errors", though that doesn’t account for unnecessary churn as seen with the blank lines at the starts of functions. Jess _______________________________________________ dev-commits-src-main@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main To unsubscribe, send any mail to "dev-commits-src-main-unsubscr...@freebsd.org"
