The branch main has been updated by mjg:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=3e875f952af05697807139b460e5124eb5f6137b

commit 3e875f952af05697807139b460e5124eb5f6137b
Author:     Mateusz Guzik <[email protected]>
AuthorDate: 2021-08-17 18:16:09 +0000
Commit:     Mateusz Guzik <[email protected]>
CommitDate: 2021-08-17 19:56:50 +0000

    pf: assert dir state on pf_test{,6}
    
    The intent is to line up various enums so that branching in the lines of:
    
    idx = (dir == PF_IN ? PF_SK_WIRE : PF_SK_STACK);
    
    is avoided.
    
    Reviewed by:    kp
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
---
 sys/netpfil/pf/pf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c
index add76c7b98d4..66c11a450030 100644
--- a/sys/netpfil/pf/pf.c
+++ b/sys/netpfil/pf/pf.c
@@ -6126,7 +6126,7 @@ pf_test(int dir, int pflags, struct ifnet *ifp, struct 
mbuf **m0, struct inpcb *
        int                      off, dirndx, pqid = 0;
 
        PF_RULES_RLOCK_TRACKER;
-
+       KASSERT(dir == PF_IN || dir == PF_OUT, ("%s: bad direction %d\n", 
__func__, dir));
        M_ASSERTPKTHDR(m);
 
        if (!V_pf_status.running)
@@ -6575,6 +6575,7 @@ pf_test6(int dir, int pflags, struct ifnet *ifp, struct 
mbuf **m0, struct inpcb
        int                      off, terminal = 0, dirndx, rh_cnt = 0, pqid = 
0;
 
        PF_RULES_RLOCK_TRACKER;
+       KASSERT(dir == PF_IN || dir == PF_OUT, ("%s: bad direction %d\n", 
__func__, dir));
        M_ASSERTPKTHDR(m);
 
        if (!V_pf_status.running)
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main
To unsubscribe, send any mail to "[email protected]"

Reply via email to