The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=1d92e81fa47925dab1fa3779b8e8e2e35d3c14ce
commit 1d92e81fa47925dab1fa3779b8e8e2e35d3c14ce Author: Warner Losh <[email protected]> AuthorDate: 2021-12-06 05:57:50 +0000 Commit: Warner Losh <[email protected]> CommitDate: 2021-12-06 06:00:01 +0000 cam/iosched: fix off by one error Set the bucket size to be SBT_1US/50000 + 1 to be the first number > 20us. I had this uncommitted in my three when I pushed 2283206935b8 since kern.cam.iosched.bucket_base_us was reporting 19us. Fixes: 2283206935b8 Sponsored by: Netflix --- sys/cam/cam_iosched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/cam/cam_iosched.c b/sys/cam/cam_iosched.c index 10caefdb02ea..4d584dc160a3 100644 --- a/sys/cam/cam_iosched.c +++ b/sys/cam/cam_iosched.c @@ -112,7 +112,7 @@ SYSCTL_INT(_kern_cam_iosched, OID_AUTO, alpha_bits, CTLFLAG_RW | CTLFLAG_TUN, * of 5.2s which is safeily larger than 1s to help diagnose extreme outliers better. */ #ifndef BUCKET_BASE -#define BUCKET_BASE (SBT_1S / 50000) /* 20us */ +#define BUCKET_BASE ((SBT_1S / 50000) + 1) /* 20us */ #endif static sbintime_t bucket_base = BUCKET_BASE; SYSCTL_SBINTIME_USEC(_kern_cam_iosched, OID_AUTO, bucket_base_us, CTLFLAG_RD,
