On Fri, Feb 04, 2022 at 10:02:05AM -0300, Renato Botelho wrote:
> On 31/01/22 11:53, Konstantin Belousov wrote:
> > The branch main has been updated by kib:
> >
> > URL:
> > https://cgit.FreeBSD.org/src/commit/?id=66c5fbca7719dca1ac361a010fa511a4514a662d
> >
> > commit 66c5fbca7719dca1ac361a010fa511a4514a662d
> > Author: Konstantin Belousov <[email protected]>
> > AuthorDate: 2022-01-28 00:57:09 +0000
> > Commit: Konstantin Belousov <[email protected]>
> > CommitDate: 2022-01-31 14:49:08 +0000
> >
> > insmntque1(): remove useless arguments
> > Also remove once-used functions to clean up after failed insmntque1(),
> > which were destructor callbacks in previous life.
> > Reviewed by: markj
> > Tested by: pho
> > Sponsored by: The FreeBSD Foundation
> > Differential revision: https://reviews.freebsd.org/D34071
>
> This change broke emulators/open-vm-tools [1]. Can you give me some advice
> to fix it?
>
> [1]
> https://github.com/vmware/open-vm-tools/blob/42ce53f39be45b7795a9f1adf892af84629b4a19/open-vm-tools/modules/freebsd/vmblock/subr.c#L396
>
error = insmntque1(vp, mp);
if (error != 0) {
VMBlockInsMntQueDtr(vp, xp);
return error;
}
It was broken before already, but in subtle way, the destructor was
not called.
