On 2022-08-16 13:47, Alexey Dokuchaev wrote:
On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote:
...
But I think it is better to have the definitions matching the
declarations exactly. We should sweep through the whole tree and get
rid of all K&R functions too. I believe Warner wanted to attempt that.
I won't comment on the technical side of things, but seeing this plethora
of identical commits is not just annoying, but pessimizes blaming as well.
I don't see any reason why this would "pessimize blaming"? What do you
mean with that?
Why can't it all be done in more coarse pieces, if not one commit?
Because then somebody else will probably complain "why everything in one
commit, it should be fine-grained"?
It has to be fixed or worked around either way. I'm now more inclined to
put in a suppression for this warning, since apparently they are just
seen as "annoying". It is probably easier to just kick the can down the
road again...
Btw, similar issues affect ports, where we can either globally suppress
new warnings (temporarily or permanently) and hope that the future won't
catch up, or gradually start fixing things. See
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265425#c13 for more
details.
-Dimitry
