From: Ravi Pokala <rpokala_at_freebsd.org> wrote on Date: Mon, 07 Nov 2022 05:33:05 UTC : > > Hi Li-Wen, > > If I'm reading this (and 72a1cb05cd23) correctly, this will run `zpool > upgrade' on the "zroot" pool on every boot. That's fine for the first time a > VM image is used, since presumably the root pool and the bootloader were > generated from the same sources. But if the root pool is subsequently > upgraded by the running VM, don't we need to make sure the bootloader is also > upgraded? Otherwise, don't we run into the possibility of this new > `zpoolupgrade' script enabling features which are not supported by the > bootloader? > > There should be some mechanism for upgrading the bootloader, or else > something else that runs on the first boot from the VM image should disable > `zpoolupgrade' so it is only run the first time.
There is also the issue of what of folks that want to maintain pools in a state compatible with a RELEASE or with a STABLE (the timing for a STABLE getting a zpool feature addition need not match main's addition of the feature), including possibly compatibility with an older loader involved. This could be an issue even for the first time a VM is booted. A means of disabling the upgrade or controlling its details might be needed. For example, someone might want to use just what is indicated in: /usr/share/zfs/compatibility.d/openzfs-2.1-freebsd (avoiding more recent additions, some of which might still be in development until openzfs-2.2 is final). > Thanks, > > Ravi (rpokala@) > > -----Original Message----- > From: <[email protected]> on behalf of Li-Wen Hsu > <[email protected]> > Date: 2022-11-06, Sunday at 19:50 > To: <[email protected]>, <[email protected]>, > <[email protected]> > Subject: git: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc script > in ZFS based VM images > > The branch main has been updated by lwhsu: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3bf53c4c8f53b1f19313e9c31415c7eee830cdc0 > > commit 3bf53c4c8f53b1f19313e9c31415c7eee830cdc0 > Author: Li-Wen Hsu <[email protected]> > AuthorDate: 2022-11-07 03:47:33 +0000 > Commit: Li-Wen Hsu <[email protected]> > CommitDate: 2022-11-07 03:47:33 +0000 > > release(7): Enable zpoolupgrade rc script in ZFS based VM images > > This will enable VM access to all ZFS feature automatically, only on a > newly installed or provisioned VM or cloud instance. > > Reviewed by: markj > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D37283 === Mark Millard marklmi at yahoo.com
