The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=d902c8f55b8da6902ab45e67ed756cc99f5a9d5a
commit d902c8f55b8da6902ab45e67ed756cc99f5a9d5a Author: Michael Tuexen <[email protected]> AuthorDate: 2024-04-06 07:55:46 +0000 Commit: Michael Tuexen <[email protected]> CommitDate: 2024-04-06 07:55:46 +0000 tcp rack: fix memory corruption When in rack_output() jumping to the label out, don't write errno into the log buffer, since the pointer is not initialized. Reported by: Coverity Scan CID: 1523773 Reviewed by: rscheff MFC after: 3 days Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D44647 --- sys/netinet/tcp_stacks/rack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index ea52eb0a92cd..5b76480ee55d 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -23718,12 +23718,12 @@ send: mtu = inp->inp_route.ro_nh->nh_mtu; } #endif /* INET */ - -out: if (lgb) { lgb->tlb_errno = error; lgb = NULL; } + +out: /* * In transmit state, time the transmission and arrange for the * retransmit. In persist state, just set snd_max.
