I think we should remove this option altogether - NG_SEPARATE_MALLOC.
 
Now, 90+% of nodes declare their own malloc(9) type.
 
For example, look at https://github.com/freebsd/freebsd-src/blob/main/sys/netgraph/ng_bridge.c#L81
 
Some people want to see this through vmstat.
 
 
31.05.2024, 21:03, "Brooks Davis" <[email protected]>:

On Fri, May 31, 2024 at 04:20:02PM +0000, Gleb Smirnoff wrote:
 The branch main has been updated by glebius:
 
 URL: https://cgit.FreeBSD.org/src/commit/?id=9b8db66402e94919ab47fc2d69863968e49e305a
 
 commit 9b8db66402e94919ab47fc2d69863968e49e305a
 Author: Dmitry Lukhtionov <[email protected]>
 AuthorDate: 2024-05-31 16:19:54 +0000
 Commit: Gleb Smirnoff <[email protected]>
 CommitDate: 2024-05-31 16:19:54 +0000
 
     netgraph: provide separate malloc type for nodes that are missing it
     
     The kernel option NG_SEPARATE_MALLOC helps to debug memory leaks in
     netgraph(4). Several nodes were missing the support.

I realize this commit didn't create the option, but is there really
enough of a cost to having multiple malloc types to justify an option at
all?

-- Brooks

Reply via email to