git: e296b0de9e46 - main - pf: some ICMP types that also have icmp_id, pointed out by markus@

[Kristof Provost]

The branch main has been updated by kp:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=e296b0de9e467b8c5eb853f6cf4c6ea28d4119a2

commit e296b0de9e467b8c5eb853f6cf4c6ea28d4119a2
Author:     Kristof Provost <k...@freebsd.org>
AuthorDate: 2024-07-10 11:32:03 +0000
Commit:     Kristof Provost <k...@freebsd.org>
CommitDate: 2024-07-29 17:42:26 +0000

    pf: some ICMP types that also have icmp_id, pointed out by markus@
    
    ok henning markus
    
    MFC after:      1 day
    Obtained From:  OpenBSD, mcbride <mcbr...@openbsd.org> 8c0632cd274b
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
---
 sys/netpfil/pf/pf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c
index 0ea68834ac63..f4832e2b5481 100644
--- a/sys/netpfil/pf/pf.c
+++ b/sys/netpfil/pf/pf.c
@@ -1808,21 +1808,21 @@ pf_icmp_mapping(struct pf_pdesc *pd, u_int8_t type,
                *icmp_dir = PF_IN;
        case ICMP_TSTAMPREPLY:
                *icmptype = ICMP_TSTAMP;
-               *icmpid = 0; /* Time is not a secret. */
+               *icmpid = pd->hdr.icmp.icmp_id;
                break;
 
        case ICMP_IREQ:
                *icmp_dir = PF_IN;
        case ICMP_IREQREPLY:
                *icmptype = ICMP_IREQ;
-               *icmpid = 0; /* Nothing sane to match on! */
+               *icmpid = pd->hdr.icmp.icmp_id;
                break;
 
        case ICMP_MASKREQ:
                *icmp_dir = PF_IN;
        case ICMP_MASKREPLY:
                *icmptype = ICMP_MASKREQ;
-               *icmpid = 0; /* Nothing sane to match on! */
+               *icmpid = pd->hdr.icmp.icmp_id;
                break;
 
        case ICMP_IPV6_WHEREAREYOU: