On Thu, 31 Oct 2024 at 15:17, Mark Millard <mark...@yahoo.com> wrote:
>
> > + # Presence of FreeBSD-* package(s) indicates packaged base.
> > + if ! pkg -c ${BASEDIR} info -q -x '^FreeBSD' 2>/dev/null; then
>
> Slight difference in the comment vs. the code's behavior? :
>
> Comment: FreeBSD-*
> Code: FreeBSD*
The code is a regex ^FreeBSD while I wrote the comment thinking of a
shell glob - it's fine that they're not identical (except for this
confusion). That said there is room for improvement here - we'll want
to detect pkgbase installs in downstream projects that use a different
package naming scheme (e.g. packages starting with CheriBSD).
I'll keep a note of this comment for any potential iteration on this.
