Lexi Winter wrote in <am1trz7o-awg1...@amaryllis.le-fay.org>:
> Colin Percival wrote in <202509172239.58hmdok9055...@gitrepo.freebsd.org>:
> >     Include a pkg package in the pkgbase repo
> >     
> > -create-packages: .PHONY create-packages-world create-packages-kernel 
> > create-packages-source create-packages-sets
> > +create-packages: .PHONY create-packages-world create-packages-kernel 
> > create-packages-source package-pkg create-packages-sets
> 
> please consider reverting this: it causes a normal source build to
> attempt to install software from ports as root, which is not right,
> and it means the base repository is polluted with a random package
> from ports, when it is supposed to only include the base system.
> 
> if this is necessary for the release media, then it should at least
> be optional and enabled by a make option, not by default.

this also breaks the build if ${LOCALBASE} is set to a non-default
value: https://people.freebsd.org/~ivy/tmp/update-packages.log

if i'm reading this right, it seems like even if this works it will
build a new pkg package every time you build src, which roughly doubles
the time it takes me to build packages.  that's going to slow down my
development workflow significantly, since i always update from packages
when testing changes.

i've reverted this locally for now so i can get some work done.

Attachment: signature.asc
Description: PGP signature

Reply via email to