On Thu, Oct 16, 2025 at 4:58 PM Mark Johnston <[email protected]> wrote: > > On Thu, Oct 16, 2025 at 04:21:45PM -0700, Rick Macklem wrote: > > Please be aware of the following snippets from "man 9 style": > > > > In general code can be considered "new code" when it makes up about 50% > > or more of the file(s) involved. This is enough to break precedents in > > the existing code and use the current style guidelines. > > > > Stylistic changes (including whitespace changes) are hard on the source > > repository and are to be avoided without good reason. > > +1 > > This kind of change accomplishes nothing except to be a source of merge > conflicts for others to deal with. >
Not to pile on, but I would also suggest to avoid touching unrelated code in a single commit if not necessary. It helps avoid entanglement in backports. > > rick > > > > On Thu, Oct 16, 2025 at 3:05 PM David E. O'Brien <[email protected]> wrote: > > > > > > CAUTION: This email originated from outside of the University of Guelph. > > > Do not click links or open attachments unless you recognize the sender > > > and know the content is safe. If in doubt, forward suspicious emails to > > > [email protected]. > > > > > > The branch main has been updated by obrien: > > > > > > URL: > > > https://cgit.FreeBSD.org/src/commit/?id=0050289464fa56ec79e060b8d8378b9ff7145a0e > > > > > > commit 0050289464fa56ec79e060b8d8378b9ff7145a0e > > > Author: David E. O'Brien <[email protected]> > > > AuthorDate: 2025-10-15 05:22:00 +0000 > > > Commit: David E. O'Brien <[email protected]> > > > CommitDate: 2025-10-16 22:02:50 +0000 > > > > > > style(9): white space after ; and around binary operators > > > > > > in for() loops. Also, use 'while', where only the > > > conditional test of 'for' was used. > > > > > > Reviewed by: sjg
