On 30 Sep 2025, at 19:39, Gleb Smirnoff wrote: > On Mon, Sep 29, 2025 at 09:16:59PM +0000, Kristof Provost wrote: > K> URL: > https://cgit.FreeBSD.org/src/commit/?id=4e7a375804e5ad4b244ce9a035fa971cbf2f0944 > K> > K> commit 4e7a375804e5ad4b244ce9a035fa971cbf2f0944 > K> Author: ItzBlinkzy <[email protected]> > K> AuthorDate: 2025-09-28 17:21:41 +0000 > K> Commit: Kristof Provost <[email protected]> > K> CommitDate: 2025-09-29 21:15:55 +0000 > K> > K> IfAPI: Added missing accessor for if_home_vnet > K> > K> Reviewed by: kp > K> Signed-off-by: Kevin Irabor <[email protected]> > > So, who is the actual author of the patch [email protected] or > <[email protected]>? > I’d assume they’re the same person, but yeah, it’s not ideal. I pulled this from GitHub and missed the discrepancy.
> The actual question is whether there is a driver that really needs to access > this field or was this added by the logic that if a field exists in struct > ifnet, a function to access it shall exist? > It’s hard to predict what fields will be relevant for out-of-tree consumers, but it seems reasonable to allow access to this one given we already allow the current vnet to be accessed too. Best regards, Kristof
