> This doesn't work.  You are reusing the same OID already used by the
> Intel subdriver.  The result is that whichever one happens to be first
> on the linker command line works and the other one doesn't.  You have to
> either use a different OID for each subdriver or have both subdrivers
> share a single boolean.

Yes, we are aware.  There's already https://reviews.freebsd.org/D54528 about 
that.

We did not feel this was urgent, especially since I intend to retire 
`machdep.hwpstate_pkg_ctrl` from the AMD driver entirely (and obsolete it in 
the Intel driver) in favor of an easier to use interface, but this has lasted 
for a while now and could prevent the same knob from working in existing Intel 
cases.

I'll move D54528 in the coming days.

-- 
Olivier Certner

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to