On Tue, 19 May 2026, Adrian Chadd wrote:
The branch main has been updated by adrian:
URL:
https://cgit.FreeBSD.org/src/commit/?id=e56f7becc7efe05acbb08162961dca574b152720
commit e56f7becc7efe05acbb08162961dca574b152720
Author: Adrian Chadd <[email protected]>
AuthorDate: 2025-11-16 03:13:59 +0000
Commit: Adrian Chadd <[email protected]>
CommitDate: 2026-05-19 05:27:59 +0000
iwx: clean up / document noise floor and RSSI fetching
* Document what iwx_rxmq_get_signal_strength() is doing in a comment,
noting what the firmware returns and what math is being done on it
to turn it into a dBm value.
* Document what iwx_get_noise() is supposed to do, that we can't just
go do math with log numbers like we're doing, but also that we're
seeing zeros in this firmware (AX210), which may mean we're decoding
using the wrong structs.
* Swizzle around the RSSI calculation as a function, add min/max RSSI
values, and calculate RSSI against the noise floor.
* And handle the lowest noise floor value - it can't be -127dBm as
that will throw things off. Cap it at -100dBm which is a little
lower than the thermal noise floor at 20MHz (-98dBm), but it matches
IWX_MIN_DBM.
Differential Revision: https://reviews.freebsd.org/D53780
Given some comments remained 1:1 the same:
initially based on https://reviews.freebsd.org/D50929
---
sys/dev/iwx/if_iwx.c | 83 ++++++++++++++++++++++++++++++++++++++++++-------
sys/dev/iwx/if_iwxreg.h | 17 ++++++++++
2 files changed, 89 insertions(+), 11 deletions(-)
--
Bjoern A. Zeeb r15:7
