The branch main has been updated by markj:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=2404d8d741f281e445233f86b0734d6dcf02c173

commit 2404d8d741f281e445233f86b0734d6dcf02c173
Author:     Mark Johnston <[email protected]>
AuthorDate: 2026-06-05 16:28:18 +0000
Commit:     Mark Johnston <[email protected]>
CommitDate: 2026-06-05 16:54:59 +0000

    linux: Drop unneeded PHOLDs
    
    There's no point in acquiring a hold if the proc lock isn't going to be
    dropped.
    
    Reviewed by:    kib
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D57468
---
 sys/i386/linux/linux_ptrace_machdep.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/sys/i386/linux/linux_ptrace_machdep.c 
b/sys/i386/linux/linux_ptrace_machdep.c
index 8d88f8540fd5..92f382d01439 100644
--- a/sys/i386/linux/linux_ptrace_machdep.c
+++ b/sys/i386/linux/linux_ptrace_machdep.c
@@ -377,10 +377,8 @@ linux_ptrace(struct thread *td, struct linux_ptrace_args 
*uap)
                }
 
                if (req == PTRACE_GETFPXREGS) {
-                       _PHOLD(p);      /* may block */
                        td2 = FIRST_THREAD_IN_PROC(p);
                        error = linux_proc_read_fpxregs(td2, &r.fpxreg);
-                       _PRELE(p);
                        PROC_UNLOCK(p);
                        if (error == 0)
                                error = copyout(&r.fpxreg, (void *)uap->data,
@@ -388,10 +386,8 @@ linux_ptrace(struct thread *td, struct linux_ptrace_args 
*uap)
                } else {
                        /* clear dangerous bits exactly as Linux does*/
                        r.fpxreg.mxcsr &= 0xffbf;
-                       _PHOLD(p);      /* may block */
                        td2 = FIRST_THREAD_IN_PROC(p);
                        error = linux_proc_write_fpxregs(td2, &r.fpxreg);
-                       _PRELE(p);
                        PROC_UNLOCK(p);
                }
                break;

Reply via email to