> On Jun 10, 2026, at 5:36 AM, Warner Losh <[email protected]> wrote: > > The branch main has been updated by imp: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=925f53682469ea12c017b48114b16e8f1627fb0b > > commit 925f53682469ea12c017b48114b16e8f1627fb0b > Author: androvonx95 <[email protected]> > AuthorDate: 2025-07-15 18:01:28 +0000 > Commit: Warner Losh <[email protected]> > CommitDate: 2026-06-10 12:35:02 +0000 > > improve renice user error messages > > Improve error handling for invalid user names and UIDs in renice: > - Use warnx() and err() for consistent error reporting > - Set errno = EINVAL for invalid input > - Provide clearer error messages for invalid user names and UIDs > - Add test cases for invalid user input > > Signed-off-by: androvonx95 <[email protected]> > Reviewed by: imp > Pull Request: https://github.com/freebsd/freebsd-src/pull/1768
... This commit is broken: - The test regexes don’t match what the program outputs. - A number of test cases were added, but not connected in `atf_init_test_cases`. - There’re some dead code paths/double warnx calls which add noise to the program output. I think it would be a good idea to revert the commit, fix the issues, then resubmit the change once the issues with the submission have been resolved. Thank you, -Enji PS Sorry for recommending you repro the issue with ghpr — this wouldn’t have likely happened had you not pushed changes that weren’t 100% tested/complete.
signature.asc
Description: Message signed with OpenPGP
