On Mon, Aug 10, 2026 at 11:57 AM Gleb Smirnoff <[email protected]> wrote: > > Kevin, > > On Sun, Aug 09, 2026 at 06:47:43AM +0000, Kevin Bowling wrote: > K> The branch main has been updated by kbowling: > K> > K> URL: > https://cgit.FreeBSD.org/src/commit/?id=1ccf543b21eff6e0828142e5c1d09519247143f4 > K> > K> commit 1ccf543b21eff6e0828142e5c1d09519247143f4 > K> Author: Eric Joyner <[email protected]> > K> AuthorDate: 2019-03-18 18:30:00 +0000 > K> Commit: Kevin Bowling <[email protected]> > K> CommitDate: 2026-08-09 06:46:29 +0000 > K> > K> ifconfig: Add SR-IOV VF status output > K> > K> - Adds SR-IOV VF status to the existing ifconfig "-v" output > K> - Adds ioctl command for reporting VF status info from drivers > K> - Adds support to iflib for drivers to handle this new ioctl > K> - Add support for ioctl in ixl(4) > K> > K> Signed-off-by: Eric Joyner <[email protected]> > K> > K> Relnotes: yes > K> Differential Revision: https://reviews.freebsd.org/D19647 > > This is not a reviewed change. The D19647 itself was not accepted 7 years > ago. > Just an URL to reviews.freebsd.org doesn't warrant that change is reviewed. > Even if it was accepted, just 7 year lag itself requires a re-review.
I reviewed it. > This particular change brings a lot of new ioctl(2) APIs. It is the opposite > of what other people were doing with ifconfig in the last years - reducing > ioctl use and switching to netlink. This was to give Eric proper credit and provenance, it is immediately replaced by an nvlist. A netlink interface is provided. What concretely is your suggestion? > Please revert this and start a proper review process. > > -- > Gleb Smirnoff
