The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=c80aface0f4662c7dc46eed3fbb27b64ab931500
commit c80aface0f4662c7dc46eed3fbb27b64ab931500 Author: Dima Ruinskiy <[email protected]> AuthorDate: 2025-02-06 16:08:46 +0000 Commit: Kevin Bowling <[email protected]> CommitDate: 2026-08-11 20:47:57 +0000 e1000: fix unchecked return DPDK commit message net/e1000/base: fix unchecked return Static analysis has detected a write that is not checked for errors, leading to ignored error return value. Add a check. Fixes: edcdb3c5f71b ("e1000/base: fix link flap on 82579") Cc: [email protected] Signed-off-by: Dima Ruinskiy <[email protected]> Signed-off-by: Anatoly Burakov <[email protected]> Acked-by: Bruce Richardson <[email protected]> Obtained from: DPDK (b0b6b50c20) MFC after: 2 weeks --- sys/dev/e1000/e1000_ich8lan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/e1000/e1000_ich8lan.c b/sys/dev/e1000/e1000_ich8lan.c index 1a3433217682..1fbdc35e74df 100644 --- a/sys/dev/e1000/e1000_ich8lan.c +++ b/sys/dev/e1000/e1000_ich8lan.c @@ -1071,6 +1071,8 @@ s32 e1000_set_eee_pchlan(struct e1000_hw *hw) data &= ~I82579_LPI_100_PLL_SHUT; ret_val = e1000_write_emi_reg_locked(hw, I82579_LPI_PLL_SHUT, data); + if (ret_val) + goto release; } /* R/Clr IEEE MMD 3.1 bits 11:10 - Tx/Rx LPI Received */
