Hi again, I've had a brief look and it looks pretty good. One thing is that I have some pending changes to EmbeddingSetup to fix some shutdown problems on linux (leaks, crash). Unfortunately the singleton idea doesn't work to well during shutdown as things aren't always destroyed in correct order. So I changed it so that there is a TermEmbedding call and a counter makes sure to only do the real termination when matching numbers of InitEmbedding/TermEmbedding have been called.
Anyway that should be quite easy to merge with your stuff. -Pelle Tristan Van Berkom wrote: > Ok I added another patch here: > https://bugzilla.mozilla.org/show_bug.cgi?id=436234 > (patch against http://hg.mozilla.org/users/blassey_mozilla.com/embedding/) > > It doesnt include the gtk+ win32 widget yet, its just the modifications I > needed > to make to the core embedding api to get the widgets basic features working. > > I will create a separate bug for the gtk+ widget, and I should do some work > on it first, change the namespace to be something gtk+ mozillaish basically. > > The gtk+ widget right now is hairy, the code is pretty clean but the > implementation > is a nightmare, I am currently using a toplevel native win32 api > window in order to activate > and disactivate focus handling based on the activate windows messages > (I didnt find > any other way to get kb focus working at all), as a consequence, I am > moving the toplevel > window in sync with the parent, which is a bit of a mess, and it also > means accelerator keys > wont work when the mozilla widget is in focus - basically this focus > issue seems to be > the one real issue that needs to be worked out. > > Cheers, > -Tristan > > On Mon, May 26, 2008 at 11:57 PM, pjohnsen <[EMAIL PROTECTED]> wrote: >> Hi Tristan, >> >> This is great. I think we would like to include a win32 version of the >> gtk widget. >> >> Dave Camp is probably the best person to look at your patch as I don't >> really know gtk, I think he should be back next week. Although the patch >> doesn't seem to be included here? >> >> Maybe we could use one of the existing bugzilla components for now (e.g. >> Embedding API's) ? >> >> Also please note that the new embedding code is still at a very early >> stage so things may still change quite a bit. >> >> -Pelle >> >> Tristan Van Berkom wrote: >>> Hi. >>> A little introduction for context, I'm working on a mozilla >>> embedding widget for >>> the win32 platform using the gtk+ framework - I was previously using >>> the 2-0-0-12 >>> release tag, had some significant issues but all-in-all, with some >>> workarounds, it >>> was working. Anyway, after a blocker bug - i.e. we werent able to get the >>> nsIURIContentListener object be called - and didnt have much more insight on >>> irc, I figures it was going to be easier to follow bleeding edge >>> development and >>> work on more current things. >>> >>> So far I managed to compile the embedding sandbox here >>> http://hg.mozilla.org/users/blassey_mozilla.com/embedding/ >>> using a trial version of MS Visual Studio and a nightly build >>> of the xulrunner-sdk for windows, and I also managed to get the >>> nsIURIContentListener object registered correctly and a callback >>> on the MozViewListener interface called correctly. >>> >>> I couldnt find the new embedding development bugzilla component/product >>> on bugzilla.mozilla.org, so I am attaching my patch here - and hope >>> you will tell me where I should attach patches in the future :) >>> >>> Please let me know your comments, about the patch, coding practices etc, >>> Im not well versed in C++ but I know the GType system by heart, so as >>> specially - I am worried there might be memory leaks - since I dont know >>> too much about nsCOMPtr and friends. Also any comments about the >>> project per say, are you guys possibly interested in including a win32 >>> gtk+ mozilla embedding widget ? any specific pitfalls I should know about ? >>> (I already found focus handling to be a nightmare in 2-0-0-12 tag, hoping >>> to improve that now...). >>> >>> Cheers, >>> -Tristan >> _______________________________________________ >> dev-embedding mailing list >> [email protected] >> https://lists.mozilla.org/listinfo/dev-embedding >> _______________________________________________ dev-embedding mailing list [email protected] https://lists.mozilla.org/listinfo/dev-embedding
