Hey again! The meeting notes last week were a hit, so here is the 2nd installment.
*2015-05-19Summary*Last week was unusually frenetic, large amounts of code were landed for both Pocket and Hello. I have never reviewed so much code in one week in my life. If Ryan Kelly starts mumbling about cross browser inconsistencies and browser bugs, do not be alarmed. Ryan is showing himself quite adept at front end development, and so far has not run away in a panic. *New Intern* Edouard, our first intern of the summer, started yesterday. I have little information other than Zach will be his local mentor. Once I learn more, I'll pass it along. *Contributors* @FaroukH has contributed a patch that to remove "ES3 only" from our JSHint rules. Thank you Farouk and Riadh for recruiting another of your friends! *Pocket* Zach and Vlad landed a ton of Pocket related functionality last week. Zach implemented a new Permissions screen [1], and Vlad added support for post-verification redirect from the "verification complete" page [2]. A new OAuth query parameter, `verfication_redirect` [3], allows reliers to configure redirection behavior after a user verifies their email. Zach and Ryan Feeley are collaborating this week to rework the permissions screen to be more understandable [4]. Vlad is adding the ability for a relier to specify only the verification tab should redirect back to the relier. Ryan Kelly landed code (today) that sends an additional query parameter, `action`, back to the relier whenever a user completes the OAuth flow [5]. `action` can be either `signin` or `signup`. This is a Pocket requested signal that allows users to see distinct welcome screens depending on whether they are a first time or returning FxA user. All this work is paying off. If you visit Pocket [6], you'll see "Sign in with Firefox." *Hello* Ryan Kelly landed code that ensures derived relier keys are sent to reliers during the sign up flow [7]. This bug prevented users from signing up to Hello in Fx Nightly. *Sync over WebChannels/First run* I have requested uplift of the Sync over WebChannel patch from Fx 40 to Fx 39. My patch caused Thunderbird tests to fail, Mark Hammond created a patch to disable the Sync over WebChannel tests on Thunderbird. Waiting for word from the tree sheriffs. Jon Petto from the Growth team and I got together on Monday to chat about integration of FxA into the new first run flow. The first run designs have yet to be finalized, though will probably be based on [8]. *Sign up emails* John Gruen is working on a patch to improve the aesthetic of our verification emails [9]. The emails will hopefully look much prettier once he is complete. *Account notification emails* I am beginning to pick up where I left off last quarter with sending notification emails on important account events. An example would be when a user adds a new device to Sync or when they change/reset their password. There is still some work to decide whether we will send these emails ourselves, or whether these will be sent by another service. Until we figure that out, the plan is to first send the necessary data from the front end to the back end that allows us to at least gauge the volume of emails that will be sent. If we decide we'll send these emails ourselves, I'll make the necessary backend changes. *Open Floor* Nick Alexander stopped by and asked a lot about Sync over WebChannels. He and I are going to follow up today. Marketing email opt-in is coming. When? We aren't sure. Engagement wants it by June 2nd, which means we may have to get it in this train. *Upcoming* Train 37 should be released this week. Train 37 will contain all of the initial Pocket/Hello changes. John Morrison (jrgm) expressed concern about the size of the changes, but has noted performance seems to be on par with previous trains. Train 38 strings will be extracted this week once train 37 is cut. Train 38 will be cut next week. Next Monday is a holiday in the US and UK, so next week's meeting is also going to take place on Tuesday at the same time (09.00 Pacific, 17.00 GMT) and place (Identity Vidyo room). If any external contributors have been lurking in the shadows and want to join us to say "hey", I formally invite you to stop by [10]. If you do not already have Vidyo Player installed, it will ask you to do so. Sorry. Until next week, Shane ---------------------------- [1] - https://github.com/mozilla/fxa-content-server/pull/2377 [2] - https://github.com/mozilla/fxa-content-server/pull/2366 [3] - https://github.com/mozilla/fxa-oauth-server/pull/255/files#diff-0f426376b964e609c5c4618eb8bed3b2R296 [4] - https://github.com/mozilla/fxa-content-server/pull/2442 [5] - https://github.com/mozilla/fxa-content-server/pull/2369 [6] - https://getpocket.com/login?ep=1 [7] - https://github.com/mozilla/fxa-content-server/pull/2385 [8] - https://www-demo5.allizom.org/en-US/firefox/38.0.5/firstrun/?f=38&v=1 [9] - https://github.com/johngruen/fxa-auth-mailer/blob/issue-35/templates/verify.html [10] - https://v.mozilla.com/flex.html?roomdirect.html&key=RVQ7pePJkXcp
_______________________________________________ Dev-fxacct mailing list [email protected] https://mail.mozilla.org/listinfo/dev-fxacct
