On 17/10/2015 05:18, John Morrison wrote:
>
> fxa-auth-mailer is an npm+git-url dependency pulled into fxa-auth-server. It
> targets #master, but shrinkwrap controls which actual sha is used. This also
> controls the git sha of fxa-content-server-l10n.
>
> The production version of fxa-content-experiments, by design, and by
> agreement, is controlled by this file[1] in fxa-content-server. The
> contents of that file determine what version is pulled at runtime. Commits
> to that file are controlled by the standard PR and review process for
> fxa-content-server. I emphasize that this process was chosen to give the
> owners of fxa-content-server flexibility and control over which experiments
> would go live, while ensuring that random commits on master or other
> branches did not go immediately to production.
Regardless of the utility of the tags themselves, I just discovered
something else that would come in handy on these repos: changelogs.
Since it will provide some modest benefit in terms of contextual
awareness, I think we should take the time to script up some release
tagging for l10n and auth-mailer. In my head it works like this:
* Tag auth-mailer releases like we would any other repo, and check that
we use the tagged git hash in the corresponding fxa-auth-server cut.
This would also build a changelog.
* Tag content-server-l10n releases when we decide which commit will ship
to production, and include a build step that can take care of various
house-keeping things like [1] and [2].
I think this can avoid adding any additional pain to the process with
appropriate scripting. But I'm not super clear on the details of how we
currently send a specific l10n commit to production.
Thoughts or objections?
Cheers,
Ryan
[1]
https://github.com/mozilla/fxa-content-server-l10n/pull/79#issuecomment-149445917
[2]
https://github.com/mozilla/fxa-content-server-l10n/issues/44#issuecomment-146425994
_______________________________________________
Dev-fxacct mailing list
[email protected]
https://mail.mozilla.org/listinfo/dev-fxacct
