I didn't say we should collect *all* z-indexes, just the "top level" ones, i.e. the ones under #screen directly and take places in the global stacking context.
Is that something that you would object too? On Wed, Sep 2, 2015 at 1:03 PM, Kevin Grandon <[email protected]> wrote: > Concatenating *all* z-index declarations into one file seems wrong to me. If > each module has its own stacking context (true in most cases I think), it > can be perfectly fine to have z-index declarations inside that file. I don't > think you would want module-specific CSS in one global z-index file. > > I do think that we could find a cleaner way to handle this, potentially in > JS/BaseModule, instead of having this in one huge file. > > Best, > Kevin > > > > On Tuesday, September 1, 2015 9:21 PM, Tim Guan-tin Chien > <[email protected]> wrote: > > > Years ago Alive concentrated all the top-level z-indexes into [1] > > [1] > https://github.com/mozilla-b2g/gaia/blob/e9d7c4e3ed/apps/system/style/zindex.css > > However I am now seeing z-index everywhere in [2] > > [2] > > $ grep -rl z-index apps/system/style > apps/system/style/action_menu/action_menu_extended.css > apps/system/style/app_titlebar.css > apps/system/style/crash_reporter/crash_reporter.css > apps/system/style/devtools/developer_hud.css > apps/system/style/entry_sheet/entry_sheet.css > apps/system/style/media_playback/media_playback.css > apps/system/style/system/initlogo.css > apps/system/style/system/system.css > apps/system/style/textselection_dialog/textselection_dialog.css > apps/system/style/themes/default/core.css > apps/system/style/window.css > apps/system/style/window_layout.css > apps/system/style/wrapper/wrapper.css > apps/system/style/zindex.css > > I can only assume they are not top-level z-index styles but there is > not way to assure of that, other than manually verifying it one by > one. Given that, I am pretty sure we have regressed since, and there > are some other z-index in files other than zindex.css that tries to > compete with it. > > Can we automate this with CSS linter? Can we fix it? Do we want to fix it? > > > Tim > _______________________________________________ > dev-fxos mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-fxos > > _______________________________________________ dev-fxos mailing list [email protected] https://lists.mozilla.org/listinfo/dev-fxos
