Note, as communicated yesterday (and in this e-mail), there will be no code reviews -- I would just rubber stamp it.
It is also unlikely code review could find bugs w/o actually running and testing the code. On Wed, Oct 28, 2015 at 3:13 PM, Sandip Kamat <[email protected]> wrote: > This will be a white label implementation that others could use in future > and potentially brand on their own. We can ask DT to fix any bugs we find > in the review. But publishing it elsewhere would have limited value. Open > to suggestions though. > > Sandip > On Oct 28, 2015 12:06 AM, "Paul Theriault" <[email protected]> wrote: > >> DT can contribute this by publishing anywhere - is there any reason to >> specifically include this in the Gaia repo? >> >> Adding unmaintained code has burnt us in the past and I don’t see any >> benefit in just dumping this code in Gaia. As someone who has partially >> been the cause of this in the past, I’d like to avoid this mistake again. >> >> >> >> >> >> >> > On 28 Oct 2015, at 5:46 pm, Tim Guan-tin Chien <[email protected]> >> wrote: >> > >> > Hi all, >> > >> > Yesterday, managers was informed by Sandip that DT would like to >> contribute to Gaia with an app called "Wallet", powered by NFC-related >> technology and APIs already implemented and landed in Gecko. >> > >> > I've talk with Yoshi on this and we agreed Mozilla can make use of this >> app, as a source of implementation reference and a manual testing tool. >> > >> > Product management have confirmed that there is no plan currently to >> brand and further develop the app as a Firefox OS app. Yoshi also stated >> that the current Gecko APIs only works with QC RIL so the app and the APIs >> will likely not useful to anyone other than partners with QC and w/ a >> special SIM. >> > >> > If this is the level of support we are happy with, I will rubber stamp >> the code dump in to ./dev_apps/ and any lint error etc. will be xfailed. >> > >> > Thanks, >> > >> > >> > Tim >> > _______________________________________________ >> > dev-fxos mailing list >> > [email protected] >> > https://lists.mozilla.org/listinfo/dev-fxos >> >>
_______________________________________________ dev-fxos mailing list [email protected] https://lists.mozilla.org/listinfo/dev-fxos
