I found the change was made in bug 1114676, but I don't really follow why :|
On 30.10.2015 15:23, Julien Wajsberg wrote: > As I said, I don't really understand why we enable webcomponents from > devtools at this moment. I'd remove this... > > Le 30/10/2015 14:21, Frederik Braun a écrit : >> Aaah, yeah. Pretty sure I must have messed up my device by going full >> developer. Though I still find it bad UX that enabling full developer >> mode may then break apps. >> >> A lot of our target audience might enable this. How would an app author >> protect against this? >> >> >> >> On 30.10.2015 14:07, Julien Wajsberg wrote: >>> But maybe you enabled using WebIDE without knowing ? I noticed it's >>> enabled by WebIDE when we switch to full permission mode, but I don't >>> know why. >>> >>> See [1]. >>> >>> I also noticed [2] but I don't know when it's run. >>> >>> [1] >>> https://dxr.mozilla.org/mozilla-central/source/devtools/client/webide/content/runtimedetails.js#145 >>> [2] >>> https://dxr.mozilla.org/mozilla-central/source/b2g/components/ProcessGlobal.js#72 >>> >>> Le 30/10/2015 13:59, Wilson Page a écrit : >>>> Freddy's right, I just checked and my dogfooding device does have >>>> webcomponents enabled for standard web content. Were we aware of this? >>>> I'm not sure what flags are used to build Foxfood builds. >>>> >>>> *W I L S O N P A G E* >>>> >>>> Front-end Developer >>>> Firefox OS (Gaia) >>>> London Office >>>> >>>> Twitter: @wilsonpage >>>> IRC: wilsonpage >>>> >>>> On Fri, Oct 30, 2015 at 12:52 PM, Julien Wajsberg >>>> <[email protected] <mailto:[email protected]>> wrote: >>>> >>>> Le 30/10/2015 12:31, Frederik Braun a écrit : >>>> > (Writing this as an app author) >>>> > >>>> > Hey, >>>> > >>>> > FxOS builds, especially dogfood builds have >>>> dom.webcomponents.enabled >>>> > set to true. >>>> >>>> From my understanding, it's not true, unless you enabled the developer >>>> mode in WebIDE ? >>>> I think it's enabled by default only in DEVICE_DEBUG=1 and DEBUG=1 >>>> profiles. >>>> >>>> > This makes Polymer and other web-components shims bail out early and >>>> > rely on the native implementation. Unfortunately, our implementation >>>> > does not seem to be very complete, so that is *for over a year* >>>> > impossible to use Brick or other web components in Firefox OS apps. >>>> > >>>> > See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1052140 >>>> > >>>> > What's the plan? :-) >>>> > >>>> > >>>> > Cheers, >>>> > Freddy >>>> > _______________________________________________ >>>> > dev-fxos mailing list >>>> > [email protected] <mailto:[email protected]> >>>> > https://lists.mozilla.org/listinfo/dev-fxos >>>> >>>> >>>> >>>> _______________________________________________ >>>> dev-fxos mailing list >>>> [email protected] <mailto:[email protected]> >>>> https://lists.mozilla.org/listinfo/dev-fxos >>>> >>>> >>> >>> >>> _______________________________________________ >>> dev-fxos mailing list >>> [email protected] >>> https://lists.mozilla.org/listinfo/dev-fxos >>> >> _______________________________________________ >> dev-fxos mailing list >> [email protected] >> https://lists.mozilla.org/listinfo/dev-fxos > > > > > _______________________________________________ > dev-fxos mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-fxos > _______________________________________________ dev-fxos mailing list [email protected] https://lists.mozilla.org/listinfo/dev-fxos
