Hi,

There is a small typo error in your code snippet [col.sortabel = blSortable;] 
witch disables column sorting functionality.

But in general i see this change valuable and will merge it to default package.

Alf 


-----Original Message-----
From: [email protected] on behalf of Alexander Schneider
Sent: Tue 2010-11-02 19:17
To: [email protected]
Subject: [oxid-dev-general] Chance request for oxid-aco.js
 
Hi,

here is a change request for the oxid-aoc.js file. Could you please change

--- Start code snipped oxid-aoc.js around line 1037 ---

     // collecting data/view/ident fields information arrays
     for ( var i=0,col; col = aColumnDefs[i]; i++ ) {
         if ( !col.ident ) {

             if ( col.formatter ) {
                 sFormatters = col.formatter;
             } else {
                 sFormatters = me.defaultFormatter;
             }

             var blSortable  = true;
             if ( col.sortable != null )
                 blSortable = col.sortable;

             aViewCols[iCtr] = { key: col.key,
                                 sortable: blSortable,
                                 resizeable: true,
                                 label: col.label,
                                 visible: col.visible,
                                 width: col.width,
                                 formatter: sFormatters };

             if (!col.visible) {
                 this.aColsTohide[iHiddenColCtr] = i;
                 iHiddenColCtr++;
             }
         } else {
             this.aIdentFields[iIdentCtr] = col.key;
             iIdentCtr++;
         }

         aDataCols[iCtr] = col.key;
         iCtr++;
     }

--- End code snipped oxid-aoc.js ---

to this

--- Start code snipped oxid-aoc.js around line 1037 ---

     // collecting data/view/ident fields information arrays
     for ( var i=0,col; col = aColumnDefs[i]; i++ ) {
         if ( !col.ident ) {

             if ( col.formatter ) {
                 sFormatters = col.formatter;
             } else {
                 sFormatters = me.defaultFormatter;
             }

             var blSortable  = true;
             if ( col.sortable != null )
                 blSortable = col.sortable;

             col.sortabel = blSortable;
             col.formatter = sFormatters;
             col.resizeable = true;

             aViewCols[iCtr] = col;

             if (!col.visible) {
                 this.aColsTohide[iHiddenColCtr] = i;
                 iHiddenColCtr++;
             }
         } else {
             this.aIdentFields[iIdentCtr] = col.key;
             iIdentCtr++;
         }

         aDataCols[iCtr] = col.key;
         iCtr++;
     }

--- End code snipped oxid-aoc.js ---

? This will save the full functionality of the yui library. In the way 
the non modified code do it you can only use the defined fields and not all.

Regards

-- 
Alexander Schneider
Geschäftsführer
myDevs GbR
___________________
[email protected]
www.mydevs.de

myDevs GbR
Alexander Schneider, Benjamin Gutman
Vogesenstrasse 2
79211 Denzlingen

_______________________________________________
dev-general mailing list
[email protected]
http://dir.gmane.org/gmane.comp.php.oxid.general

_______________________________________________
dev-general mailing list
[email protected]
http://dir.gmane.org/gmane.comp.php.oxid.general

Reply via email to