Hi Linas, thanks a lot for your reply. I see, that in OXIDs standard process this hash isnt needed anywhere else. But regarding, that this functionality is based on the user, IMO this stuff should be handled inside the user-model.
Unfortunately in our module we have to define a redirect-url with all necessary parameters needed to complete an order already in checkout-step 3 (payment). I know that this is an individual demand and doesnt justify a core-change - but also from a clean-code perspective I think that this method shouldnt be a) implemented twice and b) it should reside in its proper context (oxuser). Best, Manuel <mailto:[email protected]> [email protected] | <http://www.mediaopt.de/> www.mediaopt.de derksen mediaopt gmbh | elbestrasse 28/29 | 12045 berlin | +49 (30) 34 09 42-77 | fax-66 | Amtsgericht Charlottenburg | HRB 120935 B | ust.-id DE265886017 | geschäftsführer dipl.-ing. philipp derksen Von: [email protected] [mailto:[email protected]] Im Auftrag von Linas Kukulskis Gesendet: Donnerstag, 5. Januar 2012 14:49 An: [email protected] Betreff: Re: [oxid-dev-general] Change-Request 4.6: please move delivery-address hash to oxuser Hi, this md5 hash was made to prevent delivery address changes in order step, when you open new browser or something like that. So it's needed only in order step. if you properly managing user object during the checkout and your payment module, it should not cause any problems. Linas Kukulskis Developer <mailto:[email protected]> [email protected] Phone +370 37 333053 Fax +370 37 333054 <http://www.oxid-esales.com/?campaign=emailsignatur/lt/oxid-esales-com> www.oxid-esales.com OXID eSales AG Bertoldstraße 48, 79098 Freiburg, Germany Lithuanian Division K. Petrausko g. 26-316, Kaunas LT-44158, Lithuania Sales tax identification number: DE 231 450 866 Board of directors authorized to represent the company: Roland Fesenmayr (chairman), Eric Jankowfsky, Andrea Seeger Chairman of the supervisory board: Harald Fuchs Head office Freiburg: Bertoldstraße 48, 79098 Freiburg, Germany Court of registration: Amtsgericht Freiburg i. Br., HRB 701648, Office reference number: 06/447/41949 <http://www.oxid-esales.com/en/products/professional-edition?campaign=emails ignatur/lt/oxid-eshop-4> Beschreibung: Das Bild wurde vom Absender entfernt. OXID eShop 4 <http://www.oxid-esales.com/en/products/professional-edition?campaign=emails ignatur/lt/oxid-eshop-4> The next Generation of Premium eCommerce <http://www.oxid-esales.com/en/products/community-edition?campaign=emailsign atur/lt/oxid-eshop-ce> Beschreibung: Das Bild wurde vom Absender entfernt. OXID eShop Community Edition Latest version OXID eShop 4 as open source <http://www.oxid-esales.com/en/products/community-edition?campaign=emailsign atur/lt/oxid-eshop-ce> _____ From: [email protected] [[email protected]] on behalf of Manuel Reiß [[email protected]] Sent: Thursday, January 05, 2012 12:11 PM To: [email protected] Subject: [oxid-dev-general] Change-Request 4.6: please move delivery-address hash to oxuser Hi list, at the moment Im testing one of our payment-modules in a 4.6beta environment. I stumbled upon a new order-validation check (oxorder:: validateDeliveryAddress()), where the users address-data gets validated against a md5 hash. This hash is generated in that method, as well as in order:: getDeliveryAddressMD5(). In our module, we have to generate this parameter a bit earlier than in checkout step 4 (order) for the payment-gateway. Since I dont want to have a third copy of this method in my code, I would like to have the hash-generation once in a widely accessible context, e.g. in oxUser. Best, Manuel <mailto:[email protected]> [email protected] | <http://www.mediaopt.de/> www.mediaopt.de derksen mediaopt gmbh | elbestrasse 28/29 | 12045 berlin | +49 (30) 34 09 42-77 | fax-66 | Amtsgericht Charlottenburg | HRB 120935 B | ust.-id DE265886017 | geschäftsführer dipl.-ing. philipp derksen
<<~WRD000.jpg>>
_______________________________________________ dev-general mailing list [email protected] http://dir.gmane.org/gmane.comp.php.oxid.general
