Re #2 -- definitely use _WIN32 -- that's more generic, as it is platform-specific (which is what we mean) rather than vendor-specific.
Asaf On Mon, Mar 22, 2010 at 11:32 AM, <[email protected]> wrote: > Hi, > > i'm working on cleaning the Kiwix Windows Compilation scripts... > and have discovered a few new issues and discussion topics. > > #1 > in uuid.cpp, #ifdef WIN32 should be replaced by #ifdef _WIN32 which is > the pp reserved name. > > #2 > Should we use _WIN32 or _MSC_VER as pp variable to trigger the MS only code > ? > > #3 > unistd.h is a unix specific header and seems not to be mandatory in > fileimpl.cpp. > May we remove it? > > #4 > In zim.h there is an include of stdint.h. stdint.h is not include in MSVC. > They are > many solutions to workaround that and we started to redefine types in zim.h > specifically > for MS. Maybe a better solution would be to use a portable version of > stdint.h. Like > available here http://www.azillionmonkeys.com/qed/pstdint.h ? > > Regards > Emmanuel > > _______________________________________________ > dev-l mailing list > [email protected] > https://intern.openzim.org/mailman/listinfo/dev-l > -- Asaf Bartov <[email protected]>
_______________________________________________ dev-l mailing list [email protected] https://intern.openzim.org/mailman/listinfo/dev-l
