[
http://jira.magnolia-cms.com/browse/MAGNOLIA-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Will Scheidegger updated MAGNOLIA-2438:
---------------------------------------
Attachment: SimpleNavigationTag.patch
I modified the patch so that one has to turn it on specifically by setting the
markFirstAndLastElement attribute to true.... and I fixed the patch file so
that it only reflects the real changes, not the code "cleanup" by NetBeans.
-> I don't think that having this "on" by default is bad. The two additional
classes will not have any impact on the HTML code.
-> Still more than 50% of the users us IE which is not a CSS2 browser
But then again having to turn the feature on with a flag is not that bad either.
> Add "first" to li class on first element, "last" to li class on last element
> of level
> -------------------------------------------------------------------------------------
>
> Key: MAGNOLIA-2438
> URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2438
> Project: Magnolia
> Issue Type: Improvement
> Components: taglibs
> Affects Versions: 3.6.3
> Reporter: Will Scheidegger
> Assignee: Fabrizio Giustina
> Priority: Minor
> Attachments: SimpleNavigationTag.patch
>
> Original Estimate: 0.06d
> Remaining Estimate: 0.06d
>
> Often one would like to have the first or last nav element of a level display
> differently, e.g. an additional border. The proposed modification adds a
> "first" to the css class of the first element and a "last" to the last nav
> element of each level, i.e. to the <li> tag.
> For instance this:
> <ul class="level3">
> <li class="leaf"><a href="/magnoliaAuthor/page1.html">Link 1</a></li>
> <li class="leaf"><a href="/magnoliaAuthor/page2.html">Link 2</a></li>
> <li class="leaf"><a href="/magnoliaAuthor/page3.html">Link 3</a></li>
> <li class="leaf"><a href="/magnoliaAuthor/page4.html">Link 4</a></li>
> </ul>
> will be turned into this:
> <ul class="level3">
> <li class="leaf first"><a href="/magnoliaAuthor/page1.html">Link 1</a></li>
> <li class="leaf"><a href="/magnoliaAuthor/page2.html">Link 2</a></li>
> <li class="leaf"><a href="/magnoliaAuthor/page3.html">Link 3</a></li>
> <li class="leaf last"><a href="/magnoliaAuthor/page4.html">Link 4</a></li>
> </ul>
> Note: I did create the patch file as described in
> http://wiki.magnolia-cms.com/display/WIKI/Developer+information but the patch
> file looks strange with many many lines to be removed. Therefore I also added
> the complete, modified Java file.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
for list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
----------------------------------------------------------------
