[
http://jira.magnolia-cms.com/browse/MGNLRSSAGG-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21069#action_21069
]
Jan Haderka commented on MGNLRSSAGG-10:
---------------------------------------
bq. Attached reworked patch to match the latest version of the magnolia-module
currently in trunk (rev 22223).
Thanks. Was about to ask you if you can provide this update :)
It would be great if you can maybe provide sample of configuration for your
other use case? You use it to generate feed from small articles like news on
your site or something similar? Or do you use it to generate feeds from other
data types in data module?
Looking at your solution it seems flexible enough to generate feed from just
about anything.
If I understood it correctly you just extend {{SyndFeedGenerator}} and
implement all the abstract methods. And then you just have to specify that name
of the feed generator in the call to {{ProduceFeed.jsp}}. Correct?
Regarding your comment in the JSP - yes, absolutely. JSP should go away
completely and be replaced by either filter or servlet registered in
{{/server/filters}} respectively {{/server/filters/servlets}}. JSP was just a
poor-man's-hack to see if the POC will work out or not.
Filters are normally registered from the bootstrap files, and reodered to
proper position using {{FilterOrderingTask}} Have a look at
{{magnolia-module-cache}} for example of that.
Servlets can be registered in directly in module deployment descriptors.
{{magnolia-module-dms}} is nice example of how to do this.
Personally this feels more like the kind of work I would do in servlet rather
then filter, but no strong preference either way.
As for the resolving different feed generators I think it would be more
flexible to have them configured via admin interface, for example under
/modules/rssaggregator/config/feedGenerators rather then having to add
generator mapping on the fly in jsp page.
BTW, contrary to Philipp, I think it should stay with RSSAggregator module. ;)
It looks like a great extension to the module. Thanks.
> Enable easy syndication of any Magnolia content
> -----------------------------------------------
>
> Key: MGNLRSSAGG-10
> URL: http://jira.magnolia-cms.com/browse/MGNLRSSAGG-10
> Project: Magnolia RSS Aggregator Module
> Issue Type: Improvement
> Affects Versions: 1.0
> Reporter: Rob van der Linden Vooren
> Assignee: Jan Haderka
> Attachments: MGNLRSSAGG-10_for_rev22223.patch
>
>
> We encountered a use case of needing to syndicate other content than just the
> aggregate feeds defined in the RSS Module.
> As such, I rewrote the FeedGenerator class and the ProduceFeed.jsp to enable
> us to syndicate any content in the Magnolia repository easily.
> Please have a look at the patch and let me know what you think.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
