[
http://jira.magnolia-cms.com/browse/MGNLIMG-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22093#action_22093
]
Dean Arnold commented on MGNLIMG-32:
------------------------------------
Hi Grégory, The updates you made now allow the image filtering module to build
successfully and all unit tests pass. Thanks!
There does appears to be one other issue, the module doesn't create the
xxxx_resized node in the JCR (it *does* create the xxx_cropperInfo). I have
added the 'class' node data with a value of
'info.magnolia.module.imagefiltering.ImageFilteringDialogHandler' to my dialog
declaration. I see that the 'DialogHandlerManager' gets the Class (using
classForName) of the ImageFilteringDialogHandler, but when the save button is
clicked on the admin UI dialog, the 'onPostSave' method is not actually called.
I cannot see that an instance of the 'ImageFilteringDialogHandler' class is
ever created. I confirmed this by updating the 'ImageFilteringDialogHandler'
and 'CropAndResizeControl' classes to add logging; the logging for
'CropAndResizeControl' was printed but logging for
'ImageFilteringDialogHandler' was not.
I saw that there is a 'deprecated' at the top of the
'ImageFilteringDialogHandler' class that indicates that the handler should only
be used with 3.0 versions of magnolia. Unfortunately I couldn't find any
details in the documentation that indicate an alternative mechanism. I also
noticed that the [Magnolia 4.0
documentation|http://documentation.magnolia-cms.com/reference/dialogs.html]
still states you should extend the 'ParagraphEditDialog' when creating a custom
dialog.
Do you have a class for 3.6./4.0 that will allow the module to be triggered
correctly on save, or is there a bug in Magnolia 4.0 that is preventing it from
executing the 'ImageFilteringDialogHandler.onPostSave' method?
If you hadn't guessed, I'm, using magnolia 4.0.1.
> Unable to build checked out module
> ----------------------------------
>
> Key: MGNLIMG-32
> URL: http://jira.magnolia-cms.com/browse/MGNLIMG-32
> Project: Magnolia Image Filtering Module
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Olivier Marti
> Assignee: Grégory Joseph
>
> I checked out
> http://svn.magnolia-cms.com/svn/community/modules/magnolia-module-imagefiltering/trunk/
> but building it failed with the following exception:
> [INFO] Compilation failure
> /Users/omarti/Work/checkouts/3_Modules/magnolia-module-imagefiltering/src/main/java/info/magnolia/module/imagefiltering/ImagesProcessor.java:[164,59]
> unreported exception info.magnolia.content2bean.Content2BeanException; must
> be caught or declared to be thrown
> Also this is the case for the cropperPage.class
> Getting a svn history file allowed me then to build the jar. The following
> commit (per file) introduced the change prohibiting a proper build:
> MAGNOLIA-2245 removed deprecated/unused FreeMarkerUtil and JSPIncludeUtil
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
