[
http://jira.magnolia-cms.com/browse/MGNLRSSAGG-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22433#action_22433
]
Jan Haderka commented on MGNLRSSAGG-14:
---------------------------------------
{quote}
So what would be the expected behaviour?
* Write empty feed (title, description but no entries; this option sounds
sensible)
{quote}
>From the client point definitively write an empty feed. If I'm a reader and
>find there are no items in the feed, it is fine, next time i recheck this feed
>there will be some data so i know those are new. Happy path, no exceptional
>flow. If there is an error stack trace instead of empty feed, or no response
>at all, we depend on the behaviour of the reader and how it will deal with it
>(ignore, disable fetching of corrupted feed, ... whatever). So I think
>definitively empty feed.
{quote}
Also (not per se related to this issue but made me think of it):
* What should happen when the default feed generator is requested with a
non-existing path? (currently stacktrace is shown)
* What should happen when a custom feed generator is requested that does
not exist? (currently stacktrace is shown)
{quote}
I believe, in both of those cases stacktrace is fine since those are not errors
that can recover on their own and whoever is checking log files should find it
and fix it (or notify user to fix it).
> Feed Generator fails to produce empty feed
> ------------------------------------------
>
> Key: MGNLRSSAGG-14
> URL: http://jira.magnolia-cms.com/browse/MGNLRSSAGG-14
> Project: Magnolia RSS Aggregator Module
> Issue Type: Bug
> Affects Versions: 1.0-m2
> Environment: When feed data are not fetched yet, paragraph displays
> meaningful message, however combind feed generator fails with exception
> rather then producing empty feed.
> {code}
> Exception:
> "javax.servlet.ServletException: Failed to process request
>
> info.magnolia.module.rssaggregator.servlet.AbstractServlet.processRequest(AbstractServlet.java:89)
>
> info.magnolia.module.rssaggregator.servlet.AbstractServlet.doGet(AbstractServlet.java:58)
> ..............."
> Root Cause:
>
> "info.magnolia.module.rssaggregator.generator.FeedGenerationException: Failed
> to generate Feed using generator
> 'info.magnolia.module.rssaggregator.generator.RSSModuleFeedGenerator'
>
> info.magnolia.module.rssaggregator.generator.AbstractSyndFeedGenerator.generate(AbstractSyndFeedGenerator.java:82)
>
> info.magnolia.module.rssaggregator.servlet.FeedSyndicationServlet.handleRequest(FeedSyndicationServlet.java:70)
> ................."
> {code}
> Reporter: Jan Haderka
> Assignee: Jan Haderka
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
