[
http://jira.magnolia-cms.com/browse/MGNLFORUM-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grégory Joseph updated MGNLFORUM-66:
------------------------------------
Summary: validation of messages not taken into account for message
counters and last message references (was: Conflict between MGNLFORUM-43 and
MGNLFORUM-25)
Description:
This is a conflict between the resolutions of MGNLFORUM-43 and MGNLFORUM-25
Since MGNLFORUM-25 was resolved by adding a property to the forum nodes, which
is updated every time a message is posted, it conflicts with the resolution of
MGNLFORUM-43 : if the lastMessage is not validated or even invalidated, the
reference to lastMessage on forum is "wrong", since it points to a message
which is not visible. Thread count also has the same issue, since it simply
counts the number of children (threads), not taking into their being validated.
was:
Since MGNLFORUM-25 was resolved by adding a property to the forum nodes, which
is updated every time a message is posted, it conflicts with the resolution of
MGNLFORUM-43 : if the lastMessage is not validated or even invalidated, the
reference to lastMessage on forum is "wrong", since it points to a message
which is not visible. Thread count also has the same issue, since it simply
counts the number of children (threads), not taking into their being validated.
The {{lastMessage}} and {{firstMessage}} properties were introduced for
ease-of-use reasons. The firstMessage is needed in threads, because it is what
mostly defines this thread (in a forum, this is where the discussion is
started, where the original question is asked, etc. If you had a blog, the
{{firstMessage}} could be considered the blog post itself).
In templates, they allow to do stuff like {{${forum. lastMessage.author}}}
transparently. We could fake them by having util methods on the ForumManager,
or even wrap the nodes, this would just be less elegant and practical.
OTOH, they cause issues (MGNLFORUM-75, MGNLFORUM-62, ...) and this one.
> validation of messages not taken into account for message counters and last
> message references
> ----------------------------------------------------------------------------------------------
>
> Key: MGNLFORUM-66
> URL: http://jira.magnolia-cms.com/browse/MGNLFORUM-66
> Project: Magnolia Forum Module
> Issue Type: Bug
> Reporter: Grégory Joseph
> Assignee: Grégory Joseph
> Priority: Critical
> Fix For: 1.1
>
>
> This is a conflict between the resolutions of MGNLFORUM-43 and MGNLFORUM-25
> Since MGNLFORUM-25 was resolved by adding a property to the forum nodes,
> which is updated every time a message is posted, it conflicts with the
> resolution of MGNLFORUM-43 : if the lastMessage is not validated or even
> invalidated, the reference to lastMessage on forum is "wrong", since it
> points to a message which is not visible. Thread count also has the same
> issue, since it simply counts the number of children (threads), not taking
> into their being validated.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
