[ 
http://jira.magnolia-cms.com/browse/MAGNOLIA-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=23853#action_23853
 ] 

Grégory Joseph commented on MAGNOLIA-2644:
------------------------------------------

This seems quite interesting; eventhough I'd rather implement this sort of 
thing after some refactoring though. If you could provide a couple of 
testcases, I'd feel more comfortable applying the patch. (i.e this would ensure 
refactoring will not break these new features)

I had something else in mind, with basically the same goal - using an 
environment variable (i.e define/override {{magnolia.initialization.file}} at 
webapp-level in the container, much like you define a datasource) and also 
allow usage of OS environment variables (either by injecting their values in 
the value of {{magnolia.initialization.file}}, or by getting the value of 
{{magnolia.initialization.file}} list from the ENV)

By the way, at least with Tomcat, you can already use a variable such as 
{{${user.home}}} in {{magnolia.initialization.file}}; have you tried using 
{{${com.ibm.websphere.servlet.application.host}}} in there directly ?

> Allow property initializer to use also servlet context attributes.
> ------------------------------------------------------------------
>
>                 Key: MAGNOLIA-2644
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2644
>             Project: Magnolia
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.6.3, 4.0
>            Reporter: Danilo Ghirardelli
>            Assignee: Philipp Bärfuss
>         Attachments: ServletContext-attrib-env.patch
>
>
> On some application servers is very useful to have the property configurer 
> use also servlet context attributes and/or parameters to choose what 
> configuration file should be loaded.
> This is mainly a WebSphere issue, because one of the "recommended" cluster 
> configuration is to have multiple jvm instances on the same server. (I'm not 
> trying to say this is a good or bad choice, I only found it on some servers) 
> With the current property configurer there is no way to have a different 
> configuration for each jvm, because the only difference is the 
> "com.ibm.websphere.servlet.application.host" attribute in servlet context. 
> This particular attribute obviously works only for WebSphere, but with the 
> simple path I attached you could use any other servlet context attribute or 
> parameter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------

Reply via email to