Hi Jan, Thanks for the answer. I will stick to only deleting the tree then. The datanodes I will leave to the user to delete. And also the dialog definition.
Bye, Bert -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Jan Haderka Sent: maandag 31 augustus 2009 21:08 To: Magnolia Dev-List Subject: Re: [magnolia-dev] datamodule typedeletecommand On Mon, 2009-08-31 at 13:56 +0200, Bert Leunis wrote: > Hi there (especially Jan or Philipp!), > > > > I think the info.magnolia.module.data.commands.TypeDeleteCommand also > needs to delete the type tree and the type dialog > from /modules/data/config/. Do you agree? Deleting the data in the > rootpath of that tree is not a good idea. In the new setup of the The tree most likely yes ... the dialog ... I'm not so sure since the dialog might be reused or referenced from other places. The biggest problem with the deletion is anyway the fact that you can't delete the type definiton ... ever (more in http://jira.magnolia-cms.com/browse/MGNLDATA-30 ) Regarding the path deletion - yes, you are absolutely right, only the items of given type should be deleted from the rootpath, but not the rootpath itself, even if it is empty (since other type can have it assigned at their root path, so if you want to delete it you would have to first loop all other types definition to ensure it is not used). When fixing those issues, please add them to Jira first and assign to yourself so we can keep track of all the changes and reasons for them. Thx. Cheers, Jan ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <[email protected]> ---------------------------------------------------------------- ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <[email protected]> ----------------------------------------------------------------
