[ 
http://jira.magnolia-cms.com/browse/MGNLSTK-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26213#action_26213
 ] 

Ernst Bunders commented on MGNLSTK-564:
---------------------------------------

Some implications of this bug:

in  info.magnolia.module.templatingkit.dam.DAMSupport
the following method (line 99) will throw an AssetNotFoundException,
because the handler can no longer be resolved.

 public Asset getAsset(Content node, String nodeDataPrefix) throws
DAMException {
       String handlerName = NodeDataUtil.getString(node, nodeDataPrefix);
       final String path = node.getHandle() + "/" + nodeDataPrefix;
       if(StringUtils.isEmpty(handlerName)){
           throw new AssetNotFoundException("No handler defined for " + path);
       }
       final DAMHandler handler = handlers.get(handlerName);
       if(handler == null){
           throw new DAMException("No handler found with name [" +
handlerName + "] for [" + path + "]");
       }
       return handler.getAsset(node, nodeDataPrefix);
   }

And in info.magnolia.module.templatingkit.paragraphs.InternalTeaserModel

in the method findImage() (line 97) the following code will not find the image, 
because these properties will not be there:

for (String name : new String[]{"image", "teaserImg"}) {
            try {
                if(content.hasNodeData(name)) {
                    image = STKUtil.getAsset(content, name);
                    if(image != null){
                        return image;
                    }
                }
            }
            catch (RepositoryException e) {
                throw new RuntimeException(e);
            }
        }

I'm pretty sure there are some more places in the stk where this is broken.

> DAM Support does not work if I only have DMS handler
> ----------------------------------------------------
>
>                 Key: MGNLSTK-564
>                 URL: http://jira.magnolia-cms.com/browse/MGNLSTK-564
>             Project: Magnolia Standard Templating Kit
>          Issue Type: Bug
>          Components: controls
>    Affects Versions: 1.2
>            Reporter: Bozidar Ilievski
>            Assignee: Philipp Bärfuss
>
> I removed the "upload" handler from the damSupport, so that the Editor can 
> only choose an image from DMS.
> This is what I've done:
> Templating Kit --> Site Definitions --> <my site> --> damSupport --> handlers 
> --> upload.
> I set the "enabled" property of this content node to "false".
> This way, the Editor can only choose an image from DMS (she can not upload it 
> directly).
> If the DAM support is configured like this, with only one handler, the 
> information about the image is not saved correctly.
> For example:
> If the name of the property that stores the image is "myImage", then when 
> there are two handlers, after saving the image, in JCR browser I can see that 
> there are two nodes for the image:
> 1. myImage = dms
> 2. myImageDmsUUID = 766a6d0d-4f96-45d8-a6a6-575bace65636
> But with only one handler in place, all I get after saving the dialog is:
> 1. myImageDmsUUID = 766a6d0d-4f96-45d8-a6a6-575bace65636
> Now when I test for the existence of the "myImage" property in freemarker, I 
> get result that there is no image.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------

Reply via email to