[
http://jira.magnolia-cms.com/browse/MAGNOLIA-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26280#action_26280
]
Fabrizio Giustina commented on MAGNOLIA-2993:
---------------------------------------------
just a note if anybody will start this: be very careful with tag pooling,
according to jsp specification you should never change the value of any field
set using a tag attribute, since the container is not forced to reset them.
For example if you have two tags in page:
<tag attribute="value"/>
<tag attribute="value"/>
the setAttribute(value) method will be called only the first time, while for
the second tag the container expects that the attribute is already set by
reusing the previous tag instance. If we extract tags in helper classes me must
pay attention to this.
> Extract logic out of taglibs - reusability, testability, ...
> ------------------------------------------------------------
>
> Key: MAGNOLIA-2993
> URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2993
> Project: Magnolia
> Issue Type: New Feature
> Components: taglibs, templating
> Reporter: Grégory Joseph
> Assignee: Grégory Joseph
> Fix For: 4.3
>
>
> Some of our tags are extremely complex; testing them, fixing them, has become
> very tedious. Many of them have fuzzy logic that isn't well defined.
> Extracting this will also allow us to reuse them in Freemarker templates
> (amongst others) without depending on the taglib itself; a macro library or
> {{${mgnl}}} methods might provide a simpler/cleaner/lighter syntax.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
