[
http://jira.magnolia-cms.com/browse/MAGNOLIA-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26313#action_26313
]
Philipp Bärfuss commented on MAGNOLIA-3050:
-------------------------------------------
This is something which really gives me headache once a while. I tried to clean
up things a bit (MAGNOLIA-3015) without breaking the API so far. But having
again attributes on a binary node data is at least confusing (especially as
this methods are part of the common NodeData interface).
Knowing that any change will have side effects we can probably not improve that
before 5.0. I could agree if nd.getNodeData() is only available in a specific
BinaryNodeData interface.
> Add missing methods to BinaryNodeData for getting/setting attributes
> --------------------------------------------------------------------
>
> Key: MAGNOLIA-3050
> URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3050
> Project: Magnolia
> Issue Type: Improvement
> Reporter: Fabrizio Giustina
> Assignee: Boris Kraft
> Fix For: 4.3
>
>
> I noticed only recently that BinaryNodeData has methods for setting
> attributes like:
> {code}
> setAttribute(String name, String value)
> setAttribute(String name, Calendar value)
> {code}
> but it misses the method for setting Longs or Doubles (I was wondering why
> the image size is set as a string and not as a long in jcr, this is probably
> the reason).
> Also for getting attributes it only has:
> {code}
> public String getAttribute(String name) {
> {code}
> which is already strange since the setter already supports also Calendars.
> What about cleaning it up in order to allow all the available types? we could
> maybe just add a getNodeData(String name) method similar to the one in
> Content (making clear that a binary node data can have other node data
> nested)?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
