[
http://jira.magnolia-cms.com/browse/MAGNOLIA-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26710#action_26710
]
Zdenek Skodik commented on MAGNOLIA-2810:
-----------------------------------------
Changing dialog node type seems to me ok for standard dialog definitions, but I
don't like it in case of generics at all.
If we still want to store generic tabs for dialogs as it's (under folders;
which I guess we want because of transparency)
we'll have to update the code when there is the direct check for existence of
content type for the dialog node:
{code:title=info.magnolia.module.admininterface.DialogHandlerManager}
try {
if(dialogNode.getItemType().equals(ItemType.CONTENT)){
log.warn("Dialog definitions should be of type contentNode but [" +
dialogNode.getHandle() + "] is of type content.");
}
}
catch (RepositoryException e) {
log.error("Can't check for node type of the dialog node [" +
dialogNode.getHandle() + "]: " + ExceptionUtils.getMessage(e), e);
throw new IllegalStateException("Can't check for node type of the dialog
node [" + dialogNode.getHandle() + "]: " + ExceptionUtils.getMessage(e));
}
{code}
I don't see any really important reason why we should do such a check
especially when the type actually have no impact on functionality,
at least we would allow mgnl:content and mgnl:contentNode. Any opinions are
welcome.
> Dialog node type: change log message to debug level -- or fix all our
> bootstrap files !
> ---------------------------------------------------------------------------------------
>
> Key: MAGNOLIA-2810
> URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2810
> Project: Magnolia
> Issue Type: Improvement
> Components: admininterface
> Affects Versions: 4.1, 4.0.2
> Reporter: Grégory Joseph
> Assignee: Zdenek Skodik
> Fix For: 4.3
>
> Attachments: list of affected dialog definitions
>
>
> When updating or even installing a clean instance, there are tons of
> unnecessary log messages such as:
> {noformat}
> WARN: Dialog definitions should be of type contentNode but
> [/modules/abc/dialogs/paragraphs/xyz] is of type content.
> {noformat}
> We should either make these debug messages, or fix our own content !
> (and consider writing an update task)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
