[
http://jira.magnolia-cms.com/browse/MAGNOLIA-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26801#action_26801
]
Jan Haderka commented on MAGNOLIA-3103:
---------------------------------------
from IRC:
{color:purple}(11:32:42) gjoseph: why is this a bug?{color}
{color:purple}(11:32:52) gjoseph: just instanciate your tasks properly{color}
{color:purple}(11:33:53) gjoseph: or am i missing something?{color}
{color:blue}(11:47:21) rah003: yes and no ... if the task allows to be
instantiated with the null, then template should be able to cope with it and
vice versa - if template can't cope with it, then task should fail on
init{color}
{color:purple}(11:55:16) gjoseph: re:task - there are cases where it's
"relevant2 to have null arguments (delegates for ex) - so i'm not inclined to
fix it either way{color}
{color:blue}(11:56:22) rah003: re:task, do you mind if I just fix the
template?{color}
{color:purple}(11:56:44) gjoseph: yes{color}
{color:blue}(11:56:54) rah003: in many cases we pass in empty strings - I
really don't like that{color}
{color:purple}(11:57:03) gjoseph: for descriptions{color}
{color:purple}(11:57:17) gjoseph: not for "name"{color}
{color:blue}(12:00:20) rah003: oh really? look at CacheModuleVersionHandler or
DMS or Data or Wrokflow or should I search some more?{color}
{color:purple}(12:03:57) gjoseph: in CacheMVH, the only example I see is for
the one task of 4.1, as far as I can see all the other uses of "" are for
"nested" tasks (mostly in ArrayDelegateTask here){color}
{color:purple}(12:06:17) gjoseph: i don't really like the ""s, mind you, but
i'm not keen on "fixing" the template, because I'm not keen on allowing nulls
for these paremeters. the "correct" fix would be to disallow nulls in the ctor
like you suggested, and have an ArrayDelegateTask that -somehow- bypasses this
limitation. would pbly require some api changes{color}
{color:purple}(12:06:41) gjoseph: and there are a few more changes i'd like to
do to make the MVHs less verbose, more fluid, but no clear idea nor plan at the
moment{color}
{color:blue}(12:07:09) rah003: fair enough, I'm not saying we have to change
now, but would like to keep this ticket open{color}
{color:purple}(12:08:08) gjoseph: let's paste this conversation in it ;){color}
> Install page fails to render properly when task name or description are not
> set
> -------------------------------------------------------------------------------
>
> Key: MAGNOLIA-3103
> URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3103
> Project: Magnolia
> Issue Type: Bug
> Affects Versions: 4.3 M2
> Reporter: Jan Haderka
> Assignee: Boris Kraft
> Attachments: Screenshot-Magnolia install-update ... - Chromium.png
>
>
> See the attachment.
> To reproduce add the task with {{null}} in a name and/or description field.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
